UI typo in file preview
yfarjoun
Broad InstituteDev ✭✭✭
When previewing a file there seems to be something wrong with the output. above the window where the preview lives I see the following sentence:
Last 1708 lines are shown. Use link below to view entire file.31196
I think that 31196 is supposed to be the number of lines that the entire file has, but this is no-where indicated.
Best Answer
-
Ruchi
admin
Hey @yfarjoun, it turns out 31196 was the file size in bytes, not total line count. The sentence no longer contains file size randomly and that typo has been fixed in develop. You'll see the change in the next release of FireCloud.
If total line count is important file metadata you'd like to see on the preview page, in addition to the existing file size information in KB then I can file a ticket for that. Thanks!
Answers
Thanks for reporting this, I'll file an issue!
It would be great if, when resolved, someone mentions it in this ticket. Thanks!
@yfarjoun -- From your perspective, do you like having the line count there? If yes, what would one use it for?
well, it's good to know how much of the file I'm seeing...so if it's 100 out of 101 that's one thing, but if it's 100 out of 1M it's another...
Hey @yfarjoun, it turns out 31196 was the file size in bytes, not total line count. The sentence no longer contains file size randomly and that typo has been fixed in develop. You'll see the change in the next release of FireCloud.
If total line count is important file metadata you'd like to see on the preview page, in addition to the existing file size information in KB then I can file a ticket for that. Thanks!